Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Fix for Sass::Rails 3.x #231

Closed
wants to merge 3 commits into from
Closed

Conversation

merqlove
Copy link

@merqlove
Copy link
Author

merqlove commented Jun 1, 2015

For now seems that it stable. Tests passed.

@jcemer
Copy link

jcemer commented Jun 15, 2015

Maybe a generic solution is better. What to think about a check like this:

if defined?(super)
  super_method.arity == 1 ? ? super(source) : super
else
  view_proxy.javascript_path(source, options)
end

@merqlove
Copy link
Author

We can't do this, super_method in Ruby from 2.2+.

@jcemer
Copy link

jcemer commented Jun 15, 2015

Sorry, you are right.
Looking to the code I don't see a case that the options are used.
I think we could remove this params.

  def javascript_path(source)
     if defined?(super)
       super
     else
       view_proxy.javascript_path(source)
     end
  end

@merqlove
Copy link
Author

I don't think so. Because this is what we use as helper.
We cannot just delete it, this is View API of rjs-rails. :)

When you put requirejs_include_tag into the view, ActionView will use this method.

@merqlove
Copy link
Author

merqlove commented Oct 1, 2015

This PR was did 5 month ago.
Problem still actual.
So?

@carsomyr
Copy link
Collaborator

carsomyr commented Oct 1, 2015

@merqlove Sorry for letting this fall through the cracks. I'll issue a minor release tonight.

@merqlove
Copy link
Author

merqlove commented Oct 1, 2015

@carsomyr Ok.
Anyway Rails 3 not working with Sprockets 3, as someone mentioned in #247

@carsomyr
Copy link
Collaborator

@merqlove How does 78d43f2 look?

@carsomyr carsomyr closed this Dec 13, 2015
@merqlove
Copy link
Author

@carsomyr Thanks, looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants