manual fixes for compatibility

jwage · Mar 8, 2021 · 830cfd2 · 830cfd2
1 parent 9c2667d
commit 830cfd2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -29,4 +29,9 @@
     <rule ref="SlevomatCodingStandard.Classes.SuperfluousAbstractClassNaming.SuperfluousPrefix">
         <exclude-pattern>src/Purl/AbstractPart.php</exclude-pattern>
     </rule>
+
+    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint">
+        <!-- Ignore typed property sniff since we need to support PHP 7.2 -->
+        <exclude-pattern>tests/Purl/Test/ParserTest.php</exclude-pattern>
+    </rule>
 </ruleset>
diff --git a/src/Purl/AbstractPart.php b/src/Purl/AbstractPart.php
@@ -110,9 +110,9 @@ public function __get(string $key)
     /**
      * @param mixed $value
      */
-    public function __set(string $key, $value): AbstractPart
+    public function __set(string $key, $value): void
     {
-        return $this->set($key, $value);
+        $this->set($key, $value);
     }
 
     public function __unset(string $key): void

diff --git a/tests/Purl/Test/ParserTest.php b/tests/Purl/Test/ParserTest.php
@@ -10,7 +10,8 @@
 
 class ParserTest extends TestCase
 {
-    private Parser $parser;
+    /** @var Parser */
+    private $parser;
 
     protected function setUp(): void
     {