refactor: move mock api pool to test setup

jvandenaardweg · Dec 19, 2022 · 6431388 · 6431388
1 parent 2ac95d1
commit 6431388
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 102 deletions.
diff --git a/src/energy-socket-api.test.ts b/src/energy-socket-api.test.ts
@@ -1,38 +1,19 @@
-import { Interceptable, MockAgent, setGlobalDispatcher } from 'undici';
 import { mockBasicInformationResponse } from '@/mocks/data/basic';
 import { mockStateResponse } from '@/mocks/data/state';
 import { mockIdentifyResponse } from '@/mocks/data/identify';
-import { mockApiUrl } from '@/mocks/api';
+import { mockApiPool, mockApiUrl } from '@/mocks/api';
 import { StateResponse, SystemPutParams } from '@/types';
 import { mockEnergySocketDataResponse } from '@/mocks/data/data';
 import { mockSystemResponse } from '@/mocks/data/system';
 import { EnergySocketApi } from '@/energy-socket-api';
 
-let mockApiAgent: MockAgent;
-let mockApiPool: Interceptable;
 let energySocketApi: EnergySocketApi;
 
 const mockBasicResponse = mockBasicInformationResponse['HWE-SKT'];
 
 describe('EnergySocketApi', () => {
   beforeEach(() => {
     energySocketApi = new EnergySocketApi(mockApiUrl);
-
-    mockApiAgent = new MockAgent({
-      bodyTimeout: 10,
-      keepAliveTimeout: 10,
-      keepAliveMaxTimeout: 10,
-    });
-
-    mockApiAgent.disableNetConnect();
-
-    setGlobalDispatcher(mockApiAgent);
-
-    mockApiPool = mockApiAgent.get(mockApiUrl);
-  });
-
-  afterEach(async () => {
-    await mockApiAgent.close();
   });
 
   it('should be able to create a new instance', () => {

diff --git a/src/kwh-meter-1-phase-api.test.ts b/src/kwh-meter-1-phase-api.test.ts
@@ -1,35 +1,16 @@
 import { mockBasicInformationResponse } from '@/mocks/data/basic';
 
-import { mockApiUrl } from '@/mocks/api';
-import { Interceptable, MockAgent, setGlobalDispatcher } from 'undici';
+import { mockApiPool, mockApiUrl } from '@/mocks/api';
 import { mockKwhMeter1PhaseResponse } from '@/mocks/data/data';
 import { KwhMeter1PhaseApi } from '@/kwh-meter-1-phase-api';
 
-let mockApiAgent: MockAgent;
-let mockApiPool: Interceptable;
 let kwhMeter1PhaseApi: KwhMeter1PhaseApi;
 
 const mockBasicResponse = mockBasicInformationResponse['SDM230-wifi'];
 
 describe('KwhMeter1PhaseApi', () => {
   beforeEach(() => {
     kwhMeter1PhaseApi = new KwhMeter1PhaseApi(mockApiUrl);
-
-    mockApiAgent = new MockAgent({
-      bodyTimeout: 10,
-      keepAliveTimeout: 10,
-      keepAliveMaxTimeout: 10,
-    });
-
-    mockApiAgent.disableNetConnect();
-
-    setGlobalDispatcher(mockApiAgent);
-
-    mockApiPool = mockApiAgent.get(mockApiUrl);
-  });
-
-  afterEach(async () => {
-    await mockApiAgent.close();
   });
 
   it('should be able to create a new instance', () => {

diff --git a/src/kwh-meter-3-phase-api.test.ts b/src/kwh-meter-3-phase-api.test.ts
@@ -1,35 +1,16 @@
 import { mockBasicInformationResponse } from '@/mocks/data/basic';
 
-import { mockApiUrl } from '@/mocks/api';
-import { Interceptable, MockAgent, setGlobalDispatcher } from 'undici';
+import { mockApiPool, mockApiUrl } from '@/mocks/api';
 import { mockKwhMeter3PhaseResponse } from '@/mocks/data/data';
 import { KwhMeter3PhaseApi } from '@/kwh-meter-3-phase-api';
 
-let mockApiAgent: MockAgent;
-let mockApiPool: Interceptable;
 let kwhMeter3PhaseApi: KwhMeter3PhaseApi;
 
 const mockBasicResponse = mockBasicInformationResponse['SDM630-wifi'];
 
 describe('WaterMeterApi', () => {
   beforeEach(() => {
     kwhMeter3PhaseApi = new KwhMeter3PhaseApi(mockApiUrl);
-
-    mockApiAgent = new MockAgent({
-      bodyTimeout: 10,
-      keepAliveTimeout: 10,
-      keepAliveMaxTimeout: 10,
-    });
-
-    mockApiAgent.disableNetConnect();
-
-    setGlobalDispatcher(mockApiAgent);
-
-    mockApiPool = mockApiAgent.get(mockApiUrl);
-  });
-
-  afterEach(async () => {
-    await mockApiAgent.close();
   });
 
   it('should be able to create a new instance', () => {

diff --git a/src/mocks/api.ts b/src/mocks/api.ts
@@ -1,3 +1,4 @@
+import { MockAgent } from 'undici';
 import { SupportedDevices } from '../types';
 
 export const mockHostname = 'localhost';
@@ -7,3 +8,13 @@ export const mockFirmwareVersion = '3.1';
 export const mockProductType: SupportedDevices = 'HWE-SKT';
 export const mockProductName = 'Energy Socket';
 export const mockApiVersion = 'v1';
+
+export const mockApiAgent = new MockAgent({
+  bodyTimeout: 10,
+  keepAliveTimeout: 10,
+  keepAliveMaxTimeout: 10,
+});
+
+mockApiAgent.disableNetConnect();
+
+export const mockApiPool = mockApiAgent.get(mockApiUrl);
diff --git a/src/p1-meter-api.test.ts b/src/p1-meter-api.test.ts
@@ -1,13 +1,10 @@
 import { mockBasicInformationResponse } from '@/mocks/data/basic';
 
-import { mockApiUrl } from '@/mocks/api';
-import { Interceptable, MockAgent, setGlobalDispatcher } from 'undici';
+import { mockApiPool, mockApiUrl } from '@/mocks/api';
 import { mockP1MeterDataResponse } from '@/mocks/data/data';
 import { mockParsedTelegramResponse, mockTelegramResponse } from '@/mocks/data/telegram';
 import { P1MeterApi } from '@/p1-meter-api';
 
-let mockApiAgent: MockAgent;
-let mockApiPool: Interceptable;
 let p1MeterApi: P1MeterApi;
 
 const mockBasicResponse = mockBasicInformationResponse['HWE-P1'];
@@ -19,22 +16,6 @@ describe('HomeWizardEnergyApi', () => {
         interval: 10,
       },
     });
-
-    mockApiAgent = new MockAgent({
-      bodyTimeout: 10,
-      keepAliveTimeout: 10,
-      keepAliveMaxTimeout: 10,
-    });
-
-    mockApiAgent.disableNetConnect();
-
-    setGlobalDispatcher(mockApiAgent);
-
-    mockApiPool = mockApiAgent.get(mockApiUrl);
-  });
-
-  afterEach(async () => {
-    await mockApiAgent.close();
   });
 
   describe('constructor', () => {

diff --git a/src/water-meter-api.test.ts b/src/water-meter-api.test.ts
@@ -1,35 +1,16 @@
 import { mockBasicInformationResponse } from '@/mocks/data/basic';
 
-import { mockApiUrl } from '@/mocks/api';
-import { Interceptable, MockAgent, setGlobalDispatcher } from 'undici';
+import { mockApiPool, mockApiUrl } from '@/mocks/api';
 import { mockWaterMeterDataResponse } from '@/mocks/data/data';
 import { WaterMeterApi } from '@/water-meter-api';
 
-let mockApiAgent: MockAgent;
-let mockApiPool: Interceptable;
 let waterMeterApi: WaterMeterApi;
 
 const mockBasicResponse = mockBasicInformationResponse['HWE-WTR'];
 
 describe('WaterMeterApi', () => {
   beforeEach(() => {
     waterMeterApi = new WaterMeterApi(mockApiUrl);
-
-    mockApiAgent = new MockAgent({
-      bodyTimeout: 10,
-      keepAliveTimeout: 10,
-      keepAliveMaxTimeout: 10,
-    });
-
-    mockApiAgent.disableNetConnect();
-
-    setGlobalDispatcher(mockApiAgent);
-
-    mockApiPool = mockApiAgent.get(mockApiUrl);
-  });
-
-  afterEach(async () => {
-    await mockApiAgent.close();
   });
 
   it('should be able to create a new instance', () => {

diff --git a/vitest.setup.ts b/vitest.setup.ts
@@ -1,12 +1,22 @@
-import { afterEach, beforeEach, vi } from 'vitest';
+import { setGlobalDispatcher } from 'undici';
+import { afterAll, afterEach, beforeAll, beforeEach, vi } from 'vitest';
+import { mockApiAgent } from './src/mocks/api';
+
+beforeAll(() => {
+  setGlobalDispatcher(mockApiAgent);
+});
 
 beforeEach(() => {
   vi.useFakeTimers();
 });
 
-afterEach(() => {
+afterEach(async () => {
   vi.clearAllMocks();
   vi.clearAllTimers();
   vi.runAllTimers();
   vi.useRealTimers();
 });
+
+afterAll(async () => {
+  await mockApiAgent.close();
+});