Fix property change notification

jurihock · May 19, 2024 · 714abea · 714abea
1 parent 87ab67e
commit 714abea
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/src/Spectrality/Controls/NoteSelectorControl.cs b/src/Spectrality/Controls/NoteSelectorControl.cs
@@ -40,19 +40,19 @@ public sealed partial class NoteSelectorControl : TemplatedControlBase
   public int Octave
   {
     get => Get(ref octave);
-    set => SetAndNotify(ref octave, value).AlsoNotifyOthers();
+    set => SetAndNotify(ref octave, value).AlsoNotifyAll();
   }
 
   public string Note
   {
     get => Get(ref note);
-    set => SetAndNotify(ref note, value ?? note).AlsoNotifyOthers();
+    set => SetAndNotify(ref note, value ?? note).AlsoNotifyAll();
   }
 
   public double A4
   {
     get => Get(ref a4);
-    set => SetAndNotify(ref a4, value).AlsoNotifyOthers();
+    set => SetAndNotify(ref a4, value).AlsoNotifyAll();
   }
 
   public string NoteString => $"{Note}{Octave}";

diff --git a/src/Spectrality/Controls/TemplatedControlBase.PropertyChange.cs b/src/Spectrality/Controls/TemplatedControlBase.PropertyChange.cs
@@ -53,17 +53,12 @@ public PropertyChange AlsoNotify(params string[] propertyNames)
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public PropertyChange AlsoNotifyOthers()
+    public PropertyChange AlsoNotifyAll()
     {
       if (IsPropertyChanged)
       {
         foreach (var propertyName in PropertyOwner.DirectProperties.Keys)
         {
-          if (propertyName == PropertyName)
-          {
-            continue;
-          }
-
           PropertyOwner.DirectProperties[propertyName].Raise();
         }
       }

diff --git a/src/Spectrality/Controls/TimespanSelectorControl.cs b/src/Spectrality/Controls/TimespanSelectorControl.cs
@@ -31,7 +31,7 @@ public double? Begin
     set
     {
       if (value is null) { return; }
-      SetAndNotify(ref begin, value).AlsoInvoke(OnChange).AlsoNotifyOthers();
+      SetAndNotify(ref begin, value).AlsoInvoke(OnChange).AlsoNotifyAll();
     }
   }
 
@@ -45,7 +45,7 @@ public double? End
     set
     {
       if (value is null) { return; }
-      SetAndNotify(ref end, value).AlsoInvoke(OnChange).AlsoNotifyOthers();
+      SetAndNotify(ref end, value).AlsoInvoke(OnChange).AlsoNotifyAll();
     }
   }
 
@@ -59,14 +59,14 @@ public double? Length
     set
     {
       if (value is null) { return; }
-      SetAndNotify(ref length, value).AlsoInvoke(OnChange).AlsoNotifyOthers();
+      SetAndNotify(ref length, value).AlsoInvoke(OnChange).AlsoNotifyAll();
     }
   }
 
   public long Total
   {
     get => Get(ref total);
-    set => SetAndNotify(ref total, value).AlsoInvoke(OnChange).AlsoNotifyOthers();
+    set => SetAndNotify(ref total, value).AlsoInvoke(OnChange).AlsoNotifyAll();
   }
 
   private double? begin = 0, end = 0, length = 0;