Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to a comma-separated list of mount points #19

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update to a comma-separated list of mount points #19

merged 1 commit into from
Jan 9, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 8, 2024 •
edited
Loading

Switch to using a comma-separated list of mount points instead of a List trait (which is not very practical).

This means that instead of doing:

--XeusAddon.mounts directory1:drive1 --XeusAddon.mounts directory2:drive2

One can do:

--XeusAddon.mounts directory1:drive1,directory2:drive2

@martinRenou
Copy link
Member Author

Lots of whitespaces changes, it's easier to review with https://github.com/jupyterlite/xeus/pull/19/files?diff=split&w=1

@martinRenou martinRenou added the enhancement New feature or request label Jan 8, 2024
@DerThorsten DerThorsten merged commit 8b14ad2 into jupyterlite:main Jan 9, 2024
6 checks passed
@DerThorsten
Copy link
Collaborator

thanks!

@martinRenou martinRenou deleted the mount_points branch January 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerThorsten DerThorsten Awaiting requested review from DerThorsten

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @DerThorsten