Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint failure on CI #18

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix lint failure on CI #18

merged 1 commit into from
Jan 8, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 8, 2024

Fix the lint failure, so we can see whether the project actually builds or not:

image

martinRenou
martinRenou approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's fix the rest of the CI separately

@martinRenou martinRenou merged commit ca75437 into jupyterlite:main Jan 8, 2024
5 of 7 checks passed
@jtpio jtpio deleted the fix-lint branch January 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @martinRenou