Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xeus-cpp in the docs #162

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Adding xeus-cpp in the docs #162

merged 5 commits into from
Jan 27, 2025

Conversation

anutosh491
Copy link
Contributor

No description provided.

- [xeus-nelson](https://github.com/jupyter-xeus/xeus-nelson)
- [xeus-javascript](https://github.com/jupyter-xeus/xeus-javascript)

We are also working on bringing [xeus-cpp](https://github.com/compiler-research/xeus-cpp) and [xeus-r](https://github.com/jupyter-xeus/xeus-r) into jupyterlite, stay tuned!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're in a decent spot to get rid of this line now ;) ?!

}

funky_sin_wave(100);
```
Copy link
Contributor Author

@anutosh491 anutosh491 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran out of ideas hence simply added a funky sine wave function 😅
Hope that is okay !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should look something like this

image

@anutosh491
Copy link
Contributor Author

anutosh491 commented Jan 23, 2025

Curious if this can maybe be updated to >5

- empack >=3.1.0

@anutosh491
Copy link
Contributor Author

anutosh491 commented Jan 23, 2025

Hmm, the builds fail with this error

TaskError - taskid:post_build:jupyterlite-xeus:copy:xcpp20:libclangCppInterOp.so
PythonAction Error
Traceback (most recent call last):
  File "/home/runner/micromamba/envs/test-env/lib/python3.13/site-packages/doit/action.py", line 461, in execute
    returned_value = self.py_callable(*self.args, **kwargs)
  File "/home/runner/micromamba/envs/test-env/lib/python3.13/site-packages/jupyterlite_core/addons/base.py", line 90, in copy_one
    shutil.copy2(src, dest)
    ~~~~~~~~~~~~^^^^^^^^^^^
  File "/home/runner/micromamba/envs/test-env/lib/python3.13/shutil.py", line 468, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/test-env/lib/python3.13/shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ~~~~^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp3qtk_unq/env/envs/jupyterlite-xeus-tests/lib/libclangCppInterOp.so'

Do I need to explicitly fetch CppInterOp somewhere ? It is the shared lib needed for xeus-cpp (libclangCppInterOp.so) and is present as a dependency on the emscripten-forge recipe

requirements:
  build:
    - ${{ compiler("cxx") }}
    - cmake
    - make  # [unix]
  host:
    - nlohmann_json
    - xeus-lite >=3.0.0,<4.0
    - xeus >=5.0.0,<6.0
    - cpp-argparse
    - pugixml
    - CppInterOp

@martinRenou martinRenou added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 23, 2025
@martinRenou
Copy link
Member

bot please update snapshots

@martinRenou
Copy link
Member

As discussed in private, it seems xeus-cpp does not work alongside xeus-r

@anutosh491
Copy link
Contributor Author

anutosh491 commented Jan 23, 2025

As discussed in private, it seems xeus-cpp does not work alongside xeus-r

Yess. My latest commit should atleast fix the "install dependencies" job in the CI. Now doesn't face issues on locating libclangCppInterOp.so. The integration tests fail with the following now

    Expected: /home/runner/work/xeus/xeus/ui-tests/tests/jupyterlite_xeus.spec.ts-snapshots/jupyter-xeus-launcher-default-linux.png
    Received: /home/runner/work/xeus/xeus/ui-tests/test-results/tests-jupyterlite_xeus-Gen-eec34-python-and-xeus-lua-kernels-default-retry1/jupyter-xeus-launcher-actual.png
        Diff: /home/runner/work/xeus/xeus/ui-tests/test-results/tests-jupyterlite_xeus-Gen-eec34-python-and-xeus-lua-kernels-default-retry1/jupyter-xeus-launcher-diff.png


      18 |
      19 |     const launcher = page.locator('.jp-Launcher');
    > 20 |     expect(await launcher.screenshot()).toMatchSnapshot(
         |                                         ^
      21 |       'jupyter-xeus-launcher.png'
      22 |     );
      23 |   });
      

Converting to draft untill we figure out how the kernels are obstructing one another !

@anutosh491 anutosh491 marked this pull request as draft January 23, 2025 08:49
@martinRenou
Copy link
Member

bot please update snapshots (this will fix the ui-tests)

@martinRenou martinRenou reopened this Jan 23, 2025
@anutosh491 anutosh491 marked this pull request as ready for review January 27, 2025 10:09
@martinRenou
Copy link
Member

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 49fc94d into jupyterlite:main Jan 27, 2025
13 checks passed
@anutosh491 anutosh491 deleted the xcpp branch January 29, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants