Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jupyterlite-core 0.2.0a0 #58

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 13, 2023

References

Changes

  • update pins
    • prettier is... undecided on trailing commas for this PR. none of the settings provide a stable output 😿

  • collapse more root ./.dotwhatever noise into ./build/.cache
  • update all the versions
  • update docs
    • add compatibility matrix and prerelease install instructions
  • ???

Downstreams

The hot sdist and wheel are up on the RTD preview:

https://jupyterlite-pyodide-kernel--58.org.readthedocs.build/en/58/_static/jupyterlite_pyodide_kernel-0.2.0a0.tar.gz
https://jupyterlite-pyodide-kernel--58.org.readthedocs.build/en/58/_static/jupyterlite_pyodide_kernel-0.2.0a0-py3-none-any.whl

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl added the enhancement New feature or request label Sep 13, 2023
@bollwyvl bollwyvl force-pushed the gh-57-lab4-nb7 branch 4 times, most recently from b69c187 to 7ecc0e9 Compare September 13, 2023 20:59
@bollwyvl bollwyvl marked this pull request as ready for review September 13, 2023 21:19
@@ -1,2 +1,2 @@
"""source of truth for ``jupyterlite-pyodide-kernel``` version."""
__version__ = "0.1.1"
__version__ = "0.2.0a0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the version is done when making the release with the releaser so we can revert that changes and other bumps in the package.json: https://github.com/jupyterlite/pyodide-kernel/blob/main/RELEASE.md#specifying-a-version-spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i know: see above. I wanted to actually see something working with the interplay between the new versions.

and the check-release is showing it can handle going up to 0.2.0a1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand what bumping the version in this PR helps with?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for my understanding, and presumably lerna/yarn/esbuild/webpack's, as i was having issues with cache collisions, pulling the old packages, etc. even after blowing everything away, new envs all that.

also this leaves accurately-numbered wheels/sdist in the RTD build, as i'm trying to do downstream testing as well, due to the limited surface in this test suite and docs site.

and again, the bumper does fine on check-release, correctly going to 0.2.0a1, so won't hurt anybody.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this leaves accurately-numbered wheels/sdist in the RTD build

Are they not already "scoped" per sub-domain, for example https://jupyterlite-pyodide-kernel--58.org.readthedocs.build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downstream, i want roughly accurate epochal version numbers for e.g. pip check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version bump be reverted if downstream testing is done now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, too many things broke yesterday to get much more work in. Taking a look now at merge conflicts. I still don't really trust non-trivial packages that span the lab3/lab4 divide, and kind of feel like we're going to inherit problems if this package does.

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jupyterlab-core >=0.2.0a0
2 participants