-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jupyterlite-core 0.2.0a0 #58
Conversation
470c1dd
to
efc5d21
Compare
b69c187
to
7ecc0e9
Compare
7ecc0e9
to
8889e29
Compare
@@ -1,2 +1,2 @@ | |||
"""source of truth for ``jupyterlite-pyodide-kernel``` version.""" | |||
__version__ = "0.1.1" | |||
__version__ = "0.2.0a0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the version is done when making the release with the releaser so we can revert that changes and other bumps in the package.json
: https://github.com/jupyterlite/pyodide-kernel/blob/main/RELEASE.md#specifying-a-version-spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, i know: see above. I wanted to actually see something working with the interplay between the new versions.
and the check-release
is showing it can handle going up to 0.2.0a1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand what bumping the version in this PR helps with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for my understanding, and presumably lerna/yarn/esbuild/webpack
's, as i was having issues with cache collisions, pulling the old packages, etc. even after blowing everything away, new envs all that.
also this leaves accurately-numbered wheels/sdist in the RTD build, as i'm trying to do downstream testing as well, due to the limited surface in this test suite and docs site.
and again, the bumper does fine on check-release, correctly going to 0.2.0a1
, so won't hurt anybody.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this leaves accurately-numbered wheels/sdist in the RTD build
Are they not already "scoped" per sub-domain, for example https://jupyterlite-pyodide-kernel--58.org.readthedocs.build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downstream, i want roughly accurate epochal version numbers for e.g. pip check
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the version bump be reverted if downstream testing is done now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, too many things broke yesterday to get much more work in. Taking a look now at merge conflicts. I still don't really trust non-trivial packages that span the lab3/lab4 divide, and kind of feel like we're going to inherit problems if this package does.
d9fce18
to
09b9e75
Compare
References
Changes
./.dotwhatever
noise into./build/.cache
widgetsnbextension
stuff needs to be backported to0.1.x
, as it is causing active breakage downstream vs ipywidgets8.1.1
Downstreams
The hot sdist and wheel are up on the RTD preview: