Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the jupyterlite-core package in deployment #30

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jan 28, 2025

Upgrade the version of jupyterlite-core to the pre-released one in the deployment (https://jupyterlite.github.io/ai/lab/index.html), to allow dynamic settings.

Otherwise, the page has to be reloaded to fill the required API key settings.

Peek 2025-01-28 14-43

@brichet brichet requested a review from jtpio January 28, 2025 13:29
@brichet brichet added bug Something isn't working maintenance labels Jan 28, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

EDIT: well I would have used jupyterlite-xeus. But let's agree to disagree on the kernel choice here :P

@martinRenou martinRenou merged commit b0a4048 into jupyterlite:main Jan 29, 2025
10 of 11 checks passed
@brichet brichet deleted the update_deployment branch January 29, 2025 14:32
@brichet
Copy link
Collaborator Author

brichet commented Jan 29, 2025

Thanks for the review @martinRenou

well I would have used jupyterlite-xeus. But let's agree to disagree on the kernel choice here :P

You should open an issue to discuss it 😄

@brichet
Copy link
Collaborator Author

brichet commented Jan 29, 2025

It did not fix the issue unfortunately (or maybe we have to wait for the deployment), the jupyterlite version is a stable version and not the pre-released one:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants