-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin documentation #229
base: main
Are you sure you want to change the base?
Plugin documentation #229
Conversation
There's a docs folder that supports reStructuredText and Markdown/Myst: This is published on https://jupyterhub.github.io/nbgitpuller/ |
Thanks for the markdown suggestions; I am getting my markdown education ramped up! |
Thanks for your patience with review and your work on this @sean-morris!!! Another tip is that you can do "add suggestions to batch" and then commit multiple detail suggestions as a single commit if you inspect the changes from the "files changed" tab (and only there apparently). |
nbgitpuller/pull.py
Outdated
parser.add_argument('repo_dir', default='.', help='Path to clone repo under', nargs='?') | ||
parser.add_argument('--target-dir', default='.', help='Path to clone repo under') | ||
|
||
args = parser.parse_args() | ||
|
||
for line in GitPuller( | ||
args.git_url, | ||
args.repo_dir, | ||
branch=args.branch_name if args.branch_name else None | ||
args.target_dir, | ||
branch=args.branch_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These show up again, not part of the documentation PR right?
Btw, I typically do a lot of the following to avoid accidental commits:
git status
- what is the situation?git diff
- what is changed and unstaged?git diff --staged
- what am I about to commit?git diff HEAD~1..HEAD
- what did I commit in the last commit?
Then to correct mistakes I do:
git rebase -i HEAD~X
where X is some numbers of commits to modify up in the history, and I reorder commits, change titles, stop and edits sometimes, squash/fixup etc.git commit --amend
orgit commit --amend --no-edit
to modify the latest commit etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is embarrassing! thanks, I will pull it out. In my first moments of working on this project a bunch of months ago, I worked on the command-line args piece. I made the changes off the master branch of my fork not realizing this would cause me headaches if it didn't merge in quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a plenty of understanding with the situation @sean-morris, no worries! It is very complicated when any large or several changes are planned at the same time.
2fc249b
to
312ecde
Compare
Documentation related to creating plugins.
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
312ecde
to
0b9a5fc
Compare
I wrote up documentation on the plugin pieces here. It is quite detailed -- maybe too detailed. Please tell me what can be clarified. The PR is off main. I put the documentation in its own file, README-PLUGINSmd. That may not be standard practice so tell me if I should do something different. Good deal.
This addresses Issue #228