Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to cull named servers and default servers separately #74

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

HCharlie
Copy link

@HCharlie HCharlie commented Mar 14, 2024

addressing issue, add options to cull named servers only and default servers only

Fixes #73

Copy link

welcome bot commented Mar 14, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@HCharlie HCharlie closed this Mar 14, 2024
@HCharlie HCharlie deleted the MLX-1204 branch March 14, 2024 16:02
@HCharlie HCharlie restored the MLX-1204 branch March 14, 2024 16:03
@HCharlie HCharlie reopened this Mar 21, 2024
@HCharlie HCharlie changed the title MLX-1204 add options to cull named servers and default servers only MLX-1204 add options to cull named servers and default servers separately Mar 21, 2024
@HCharlie HCharlie changed the title MLX-1204 add options to cull named servers and default servers separately add options to cull named servers and default servers separately Apr 23, 2024
@yuvipanda yuvipanda requested a review from minrk June 11, 2024 01:34
@yuvipanda
Copy link
Collaborator

Apologies for the late review, @HCharlie! I think this looks good, I made a minor change to help clarify the code a little more. Going to merge now.

@yuvipanda yuvipanda merged commit 9212191 into jupyterhub:main Jun 11, 2024
10 checks passed
@HCharlie HCharlie deleted the MLX-1204 branch June 11, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to cull idle named servers only without interfering idle default servers
3 participants