LockerV3: add batch vesting escrow lock creation #25
Conversation
| escrow_metadata.name = params.name.clone(); | ||
| escrow_metadata.description = params.description.clone(); | ||
| escrow_metadata.creator_email = params.creator_email.clone(); | ||
| escrow_metadata.recipient_email = params.recipient_email.clone(); |
There was a problem hiding this comment.
We dont need recipient email here because there are many recipients in escrow v3
There was a problem hiding this comment.
To reuse VestingEscrowMetadata in this case. Should we use empty string (recipient_email = "") ?
There was a problem hiding this comment.
can, you can validate recipient_email == ""
There was a problem hiding this comment.
In vesting_escrow_metadata, we don't need recipient_email, but we need an endpoint for merkle_tree_api, that also be string, could you combine recipient_email and merkle_tree_api in a common field, so we can make the endpoint work for both escrow v1 and escrow v3?
There was a problem hiding this comment.
i have updated recipient_endpoint field and make it common for both v1 & v2.
There was a problem hiding this comment.
I have removed create_escrow_metadata_v3 and make common function create metadata for both v1 & v2
No description provided.