Finish move to client controller and fix RBAC generation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangelajo
force-pushed
the
fix-client-rbac
branch
from
4f2b400 to
ecd9258
Compare
NickCao
approved these changes
Aug 22, 2024
mangelajo
commented
Aug 22, 2024
| @@ -18,8 +18,6 @@ rules: | |||
| - get | |||
| - list | |||
| - watch | |||
| - create | |||
There was a problem hiding this comment.
wait this should have not been removed
There was a problem hiding this comment.
These are not removed, just the order changed.
There was a problem hiding this comment.
Now it's order yes, I force-pushed in the middle before you had another look:-) I found it because it was actually failing
RBAC files are now generated in the right directory, and we generate the permissions for Client and not for Identity.
mangelajo
force-pushed
the
fix-client-rbac
branch
from
ecd9258 to
4ce0845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBAC files are now generated in the right directory, and we generate the permissions for Client and not for Identity.