Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More build script fixes and tweaks #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

  1. Explicitly use Bash, instead of worrying about being compatible with any shell.
  2. Use ${foo:?} whenever possible, to make sure that variables are defined and not empty.
  3. At the beginning of the script, make sure all dependencies exist, before we start running any commands.

Also includes the macOS sed fix from #8.

@DilumAluthge
Copy link
Member Author

Bump @IanButterworth

@IanButterworth
Copy link
Member

Go for it, if you've tested this

@DilumAluthge
Copy link
Member Author

I need to do some more testing. For now, I'll cut [email protected] off of your #8 branch.

@DilumAluthge DilumAluthge marked this pull request as draft July 21, 2024 21:33
@DilumAluthge DilumAluthge removed the request for review from IanButterworth July 21, 2024 21:33
@DilumAluthge DilumAluthge force-pushed the dpa/more-build-fixes branch from 874bfe3 to 9296a9e Compare July 21, 2024 22:00
@DilumAluthge DilumAluthge changed the title More build script fixes More build script fixes and tweaks Jul 21, 2024
@DilumAluthge DilumAluthge force-pushed the dpa/more-build-fixes branch from f4bb7cb to 7ec4da1 Compare July 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants