Simple bug fixes #254
Merged
Simple bug fixes #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive decided to try to fix the huge commit mess from a few months ago, and cut it down to more bite sized commits. These two one line bug fixes should be a good start.
The first bugfix is explicitly loading the ghosts during the level load process so, currently it is the menu leaderboard that loads the ghosts, and this creates issues for custom levels as they only load the leaderboard once a time has been set, before that they will load the last active set of ghosts which may be from a different level. Explicitly loading the correct ghosts during level load fixes this.
The other bugfix is that the replays don't load the ship parameters that are stored in the replay files, when relevant this causes stuttering.