Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mostly mesh io #9

Merged
merged 7 commits into from
Jan 24, 2017
Merged

mostly mesh io #9

merged 7 commits into from
Jan 24, 2017

Conversation

kwagstyl
Copy link

@kwagstyl kwagstyl commented Nov 7, 2016

Hi,

Here's the not to useful mesh layers code.
Also a couple of corrections on the io_mesh with how nibabel was being used.
The minc mni writing isn't quite working yet.

@kwagstyl
Copy link
Author

kwagstyl commented Nov 8, 2016

Also added write mesh data

Copy link
Owner

@juhuntenburg juhuntenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kwagstyl , cool thanks for this! Just a mini-question: why not importing nibabel as nb? Would be consistent with what we do in the other files.
Thanks!

@kwagstyl
Copy link
Author

Hi @juhuntenburg ,
I think one of the functions that was in the file used nibabel not nb, and at the time I just wanted to get it to work. In retrospect keeping consistency is worth the minor extra effort so I'll go change it

@juhuntenburg
Copy link
Owner

Cool, thanks!

@juhuntenburg juhuntenburg merged commit 6d55791 into juhuntenburg:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants