Added CW-SSIM for computing SSIM in complex wavelet domain #12
Conversation
|
Could you fix the pylint errors? See the README for how to run it. |
| @@ -0,0 +1,3 @@ | |||
| *.pyc | |||
There was a problem hiding this comment.
These should be in your global .gitignore, rather than the project one.
See: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
There was a problem hiding this comment.
alright, I removed the .gitignore again
|
Could you also add a command-line flag to use this new algorithm and add a test that uses it in |
|
Alright, I tried to address all your remarks in the last commit. |
|
hmm what's going on in the Travis build, there are strange errors. I also added Python 3.4 to the .travis.yml because I am using it on my machine and it works nice; however, there is also some issue in Travis. |
|
Alright, I could resolve all the errors; I rebased the PR to a nice commit. Btw. I added conda to Travis, to speed up the tests; also I removed python 3.2 (it should not be used) and added python 3.3 and 3.4 to Travis. I added tests, some description in the README, some command line arguments and the Reference to the paper. Let me know if you need further adjustments ;) |
|
I almost forgot; there is also the IPython file in the root folder (comparing the 2 methods) and the PDF paper in the readings folder. Hope that's ok - if not then I will remove them. |
|
Yeah, 3.2 was broken at head too. You actually managed to fix the errors? Sweet! |
|
|
||
| before_install: | ||
| - sudo apt-get install -qq python-numpy python-scipy python3-numpy python3-scipy | ||
| - wget http://repo.continuum.io/miniconda/Miniconda-latest-Linux-x86_64.sh -O miniconda.sh |
|
Just two minor comments and it's ready to merge. Thanks for the contribution! |
Added comments and fixed docstrings. Added py3.3 and py3.4 to travis. Removed py3.2. Added cw, width and height arguments. Added tests. Added reference in README. Fixed .travis.yml and added conda. Cleaned .travis.yml
|
alright, here we go. |
Added CW-SSIM for computing SSIM in complex wavelet domain
|
Nice contribution. Thank you! |
|
Once thing I forgot - will you send me a followup CL to add yourself to the AUTHORS file? |
Hi guys,
thanks for your nice library! I added SSIM computation in complex wavelet domain (IMAGE SIMILARITY IN COMPLEX WAVELET DOMAIN from Zhou Wang and Eero P. Simoncelli), which is invariant to translation and rotation. I added an IPhython notebook with the examples and benchmarks.
Best,
Christoph