-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create countdown extension #90
Conversation
🦋 Changeset detectedLatest commit: 8a7f30d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Awesome 🥳 Can you update the main README to add this to the list? I think it would also be useful in the docs to be clear when the countdown occurs (before/during trial?) |
I made the updates. But I do not see why the checks should fail when they passed before I made these changes. After all, I did not even make any changes to the code. I took a look at the log and I saw that the error occurred in the video-several-keyboard-responses plugin, but that pr was merged weeks ago, so how could it still affect the current check? |
Not sure what happened with the checks. I'm guessing one of the tests in the video-several-keyboard-response plugin has some kind of randomization built in and failed due to an outlier case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple quick things in the package file.
@jodeleeuw This already happened once in the |
I think the problem is that the simulate method wasn't updated to reflect the possibility of multiple responses. The solution might be to remove the simulation capability for now, or see if @marianylund is willing to work on the fix. |
I have frequently encounted cases where I need to add a countdown display to a trial. Therefore, I have created this countdown extension to enable this without making a mess of the code (previously there was a lot of extra work to be done in
on_load
andon_finish
).