feat: get arg type information from schema #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JSON schema, `type` can be an array if multiple types are allowed.
| ``` | ||
|
|
||
| PARAMETERS: |
There was a problem hiding this comment.
Not sure I quite understand why PARAMETERS and Arguments are two sections
There was a problem hiding this comment.
Good question, I followed the suggestion from this issue: #8
Didn't think it through, I gladly discuss that for a bit, I've seen both words in jsonnet docs, not sure about the context.
julienduchesne
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to the
type,defaultandenums, this PR introduces the ability pass along a JSONschemafor args (parameters). It has a much richer set of features to validate arguments.The render output only surfaces
type,defaultandenumfields for now.This PR also renders the docs (forgot that in #56)