Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7 packages #14

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Add 7 packages #14

merged 2 commits into from
Dec 9, 2024

Conversation

ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Dec 4, 2024

  • Are you the package author?
  • Downloaded, extracted, and reviewed the contents of the package tarball on the npm public registry.
  • Checked README, LICENSE, COPYING, and header comments for conflicting or additional licenses.
  • Searched for "license", such as with fgrep -ir license $PACKAGE_DIRECTORY.
  • Compared the license text found to standard language on htts://spdx.org/licenses/.
  • Asked the package author about the applicable license.

Notably

  • @andrewbranch/untar.js has an ambiguous license deceleration in untar.js.
  • For atomically I only bothered to check the v2 release line, not v1.
  • The first two versions of jsonp were shipped without any license statement (hence they're omitted).

See also:

Checked all versions individually. Notably the first two versions of the
jsonp package shipped without any license statement, hence they're
omitted. For atomically I only bothered to check the v2 release line,
not v1.
index.csv Outdated Show resolved Hide resolved
index.csv Show resolved Hide resolved
index.csv Show resolved Hide resolved
index.csv Show resolved Hide resolved
index.csv Show resolved Hide resolved
index.csv Show resolved Hide resolved
index.csv Show resolved Hide resolved
Copy link
Member

@kemitchell kemitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm exhausted, and not really up to checking this all from scratch again. But I think we hit all the initial feedback I had, I'd rather just release and go back and fix things later if there's some kind of nuanced issue, and, most importantly, I don't want to block this very appreciated contribution!

@kemitchell kemitchell merged commit b7400d3 into jslicense:main Dec 9, 2024
@kemitchell
Copy link
Member

Published as 1.7.0.

@kemitchell
Copy link
Member

Thanks so much for this, @ericcornelissen. I hope some of the other data in this package has been useful to you.

@ericcornelissen ericcornelissen deleted the patch-1 branch December 9, 2024 09:24
@ericcornelissen
Copy link
Contributor Author

I hope some of the other data in this package has been useful to you.

It has been 🙂 Thanks a lot for the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants