Fix absolute path import typings (#72)

* Add build check for absolute path typings

* Fix typings

package.json

@@ -26,7 +26,8 @@
         "compile:src": "tsc -p src",
         "lint:codegen": "tslint -p codegen/tsconfig.json -c tslint.json",
         "lint:src": "tslint -p src/tsconfig.json -c tslint.json",
-        "lint": "npm-run-all -p lint:codegen lint:src",
+        "lint:types": "./scripts/check-typings.sh",
+        "lint": "npm-run-all -p lint:codegen lint:src lint:types",
         "node:codegen": "node codegen/dist/emit",
         "test": "jest --config jest.config.json",
         "prepack": "yarn build",

scripts/check-typings.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+if grep -q 'import(".*")\.' dist/**/*.d.ts; then 
+    echo "ERROR: Found import() typings in dist .d.ts files. Check for exported values with inferred types."
+    exit 1
+else
+    echo "No problematic typings found."
+fi

src/measure/measure.ts

@@ -1,8 +1,8 @@
-import { createMeasureType, GenericMeasure } from "./genericMeasure";
+import { createMeasureType, GenericMeasure, GenericMeasureFactory } from "./genericMeasure";
 import { Unit } from "./unitTypeArithmetic";
 
 export type Measure<U extends Unit> = GenericMeasure<U, number>;
-export const Measure = createMeasureType({
+export const Measure: GenericMeasureFactory<number> = createMeasureType({
     guard: (value): value is number => typeof value === "number",
     one: () => 1,
     neg: x => -x,

src/quantity/quantities.ts

@@ -1,10 +1,12 @@
+import { GenericMeasure } from "../measure/genericMeasure";
 import { Measure } from "../measure/measure";
 import * as Base from "../unit/base";
 
 // Dimensionless
 
 /** A measure without any unit */
-export const Dimensionless = Measure.dimensionless(1);
+// HACKHACK: Explicitly type this so we can import GenericMeasure and avoid absolute paths in the generated typings.
+export const Dimensionless: GenericMeasure<{}, number> = Measure.dimensionless(1);
 export type Dimensionless = typeof Dimensionless;
 
 // Base units

src/unit/base.ts

@@ -1,6 +1,8 @@
+import { GenericMeasure } from "../measure/genericMeasure";
 import { Measure } from "../measure/measure";
 
-export const meters = Measure.dimension("length", "m");
+// HACKHACK: Explicitly type this so we can import GenericMeasure and avoid absolute paths in the generated typings.
+export const meters: GenericMeasure<{ length: 1 }, number> = Measure.dimension("length", "m");
 export const kilograms = Measure.dimension("mass", "kg");
 export const grams = Measure.of(0.001, kilograms, "g");
 export const seconds = Measure.dimension("time", "s");

src/unit/metric.ts

@@ -1,5 +1,6 @@
+import { Exponent } from "../exponent";
+import { GenericMeasure } from "../measure/genericMeasure";
 import { Measure } from "../measure/measure";
-import { Unit } from "../measure/unitTypeArithmetic";
 import * as Quantity from "../quantity/quantities";
 import { amperes, candelas, kilograms, meters, moles, seconds, steradians } from "./base";
 
@@ -23,7 +24,14 @@ export const luxes: Quantity.Illuminance = lumens.per(meters.squared()).withSymb
 
 // Prefixes
 
-function createPrefix(symbolPrefix: string, multiplier: number): <U extends Unit>(unit: Measure<U>) => Measure<U> {
+// HACKHACK: Many of the typings here could be made more simple but instead use their base types to avoid absolute paths
+// in the generated typings.
+function createPrefix(
+    symbolPrefix: string,
+    multiplier: number,
+): <U extends Partial<{ [dimension: string]: Exponent }>>(
+    unit: GenericMeasure<U, number>,
+) => GenericMeasure<U, number> {
     return unit => {
         const { symbol } = unit;
         const newSymbol = symbol !== undefined ? `${symbolPrefix}${symbol}` : undefined;