Enforce typedefs for functions and parameters (#49)

src/measure/math.ts

@@ -67,28 +67,22 @@ export function sum<U extends Unit>(first: Measure<U>, ...rest: Array<Measure<U>
     return result;
 }
 
-function wrapUnary(f: (x: number) => number) {
-    return <U extends Unit>(x: Measure<U>): Measure<U> => {
-        return Measure.of(f(x.value), x.normalized());
-    };
+function wrapUnary(f: (x: number) => number): <U extends Unit>(x: Measure<U>) => Measure<U> {
+    return x => Measure.of(f(x.value), x.normalized());
 }
 
-function wrapTrig(f: (x: number) => number) {
-    return (angle: PlaneAngle): Dimensionless => {
-        return Measure.dimensionless(f(angle.value));
-    };
+function wrapTrig(f: (x: number) => number): (angle: PlaneAngle) => Dimensionless {
+    return angle => Measure.dimensionless(f(angle.value));
 }
 
-function wrapInverseTrig(f: (x: number) => number) {
-    return (angle: Dimensionless): PlaneAngle => {
-        return Measure.of(f(angle.value), radians);
-    };
+function wrapInverseTrig(f: (x: number) => number): (angle: Dimensionless) => PlaneAngle {
+    return angle => Measure.of(f(angle.value), radians);
 }
 
-function warpNary(f: (...x: number[]) => number) {
-    return <U extends Unit>(first: Measure<U>, ...rest: Array<Measure<U>>): Measure<U> => {
-        return Measure.of(f(...values(first, ...rest)), first.normalized());
-    };
+function warpNary(
+    f: (...x: number[]) => number,
+): <U extends Unit>(first: Measure<U>, ...rest: Array<Measure<U>>) => Measure<U> {
+    return (first, ...rest) => Measure.of(f(...values(first, ...rest)), first.normalized());
 }
 
 function values<U extends Unit>(...measures: Array<Measure<U>>): number[] {

src/measure/measure.ts

@@ -6,7 +6,7 @@ import { dimension, divideUnits, exponentiateUnit, multiplyUnits } from "./units
 export class Measure<U extends Unit> {
     // Construction functions
 
-    public static dimension<Dimension extends string>(dim: Dimension, symbol?: string) {
+    public static dimension<Dim extends string>(dim: Dim, symbol?: string): Measure<{ [D in Dim]: 1 }> {
         return new Measure(1, dimension(dim, symbol), symbol);
     }
 

src/quantity/__test__/quantityTests.ts

@@ -4,7 +4,7 @@ import * as Quantity from "../quantities";
 describe("Quantities", () => {
     const QuantityNames = Object.keys(Quantity);
 
-    function forEachQuantity(fn: (quantity: Measure<any>, name: string) => void) {
+    function forEachQuantity(fn: (quantity: Measure<any>, name: string) => void): void {
         QuantityNames.forEach(name => {
             fn((Quantity as any)[name], name);
         });

src/unit/__test__/unitTests.ts → src/unit/__test__/predefinedUnitTests.ts

@@ -3,10 +3,10 @@ import * as Units from "../../unit";
 import { meters } from "../base";
 import { kilo, micro } from "../metric";
 
-describe("Units", () => {
+describe("Predefined Units", () => {
     const UnitNames = Object.keys(Units);
 
-    function forEachUnit(fn: (unit: Measure<any>, name: string) => void) {
+    function forEachUnit(fn: (unit: Measure<any>, name: string) => void): void {
         UnitNames.forEach(name => {
             const value = (Units as any)[name];
             if (value instanceof Measure) {

src/unit/metric.ts

@@ -23,8 +23,8 @@ export const luxes: Quantity.Illuminance = lumens.per(meters.squared()).withSymb
 
 // Prefixes
 
-function createPrefix(symbolPrefix: string, multiplier: number) {
-    return <U extends Unit>(unit: Measure<U>): Measure<U> => {
+function createPrefix(symbolPrefix: string, multiplier: number): <U extends Unit>(unit: Measure<U>) => Measure<U> {
+    return unit => {
         const symbol = unit.getSymbol();
         const newSymbol = symbol !== undefined ? `${symbolPrefix}${symbol}` : undefined;
         return Measure.of(multiplier, unit, newSymbol);

tslint.json

@@ -20,6 +20,11 @@
                 "order": "statics-first"
             }
         ],
-        "ordered-imports": true
+        "ordered-imports": true,
+        "typedef": [
+            true,
+            "call-signature",
+            "parameter"
+        ]
     }
 }