This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Use superclass defaults rather than relying on copied defaults. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows '#' as comment, as the superclass allows. It also means we don't have to keep our hardcoded defaults in sync with the superclass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows '#' as comment, as the superclass allows. It also means we
don't have to keep our hardcoded defaults in sync with the superclass.
The branch is called upgrade-2.x, because I was upgrading to recent ruby-versions, only to find out this had been done recently already and I was simply out of sync. Oops.
This commit is the only one that still makes sense after rebasing.