Skip to content

Commit

Permalink
include sprockets-rails in dependencies for rails 7.0.0 tests
Browse files Browse the repository at this point in the history
Not sure if this is really the best way to test, but it gets tests to pass for now. We're trying to test cocoon works with our attributes, and I guess cocoon is currently only doing sprockets though... so I guess it is best.

Maybe we should include our own cocoon-like JS via some other method in the future... nathanvda/cocoon#555
  • Loading branch information
jrochkind committed Dec 22, 2021
1 parent 501bc9c commit 6188c8e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ appraise "rails-7-0" do
gem "rails", "~> 7.0.0"
gem "pg", "~> 1.0"

# to make our integration tests using simple_form work as-is,
# this works. Don't totally underestand the actual simple_form
# setup paths in Rails 7....
gem "sprockets-rails"
end

appraise "rails-edge" do
Expand All @@ -53,8 +57,8 @@ appraise "rails-edge" do
gem "rails", git: "https://github.com/rails/rails.git", branch: "main"
gem "pg", "~> 1.0"

# Current rails 7 master doesn't have sprockets-rails as a dependency.
# We don't actually USE sprockets, but we're using "combustion"
# gem for rails app setup, which is assumign it. So.
# We do some tests using cocoon, currently via sprockets-rails,
# which is not automatically available in Rails 7. Not sure
# the future of cocoon in general. https://github.com/nathanvda/cocoon/issues/555
gem "sprockets-rails"
end
1 change: 1 addition & 0 deletions gemfiles/rails_7_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ gem "capybara", "~> 3.0"
gem "webdrivers", "~> 4.0"
gem "selenium-webdriver"
gem "byebug"
gem "sprockets-rails"

gemspec path: "../"

0 comments on commit 6188c8e

Please sign in to comment.