jq_fuzz_execute: fix memory leak #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <[email protected]>
wader
reviewed
Dec 2, 2023
| // Do not free "input" as this is handled by jq_teardown. | ||
| else { | ||
| // Only free if input as invalid as otherwise jq_teardown | ||
| // frees it. |
There was a problem hiding this comment.
So if understand it correctly: jq_parse will always return something allocated. If valid the input argument will end up on the stack by jq_start and freed during teardown. If invalid it needs to be freed explicitly?
There was a problem hiding this comment.
Yes, that's how I understand it.
There was a problem hiding this comment.
"is invalid"?
Ah yes, good catch. Fixed.
wader
reviewed
Dec 2, 2023
Signed-off-by: David Korczynski <[email protected]>
wader
approved these changes
Dec 2, 2023
Signed-off-by: David Korczynski <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64626