DRAFT: carousel revamp #4635
DRAFT: carousel revamp #4635
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Fercas123
force-pushed
the
revamp-carousel
branch
from
be6e19b to
da3e255
Compare
| */ | ||
| id?: string; | ||
| bordered?: boolean; |
There was a problem hiding this comment.
Styles might need to be checked, currently this shifts the alignment
There was a problem hiding this comment.
that's intentional, but the prop name might not give it very clearly... I will check this with @ivan-calderon but there is a Hero (transparent) version and a...norther(bordered) one hahaha will check the naming
| const ControlsLabel = () => ( | ||
| <Text as="span"> | ||
| <strong> | ||
| {/* TODO: check w dev, this will need changing or a formatter*/} |
There was a problem hiding this comment.
Probably fine for now, we should align with Pagination
There was a problem hiding this comment.
you mean secondary & no bold? pagination seem to be forcing the of in, no formatter... should there be one to allow users to format the info?
| ); | ||
| const Controls = () => ( | ||
| <div role="group" className={withBaseName("controls")}> | ||
| {/* TODO: check w dev, currently some props are in the context and some out, should title go in context? */} |
There was a problem hiding this comment.
Personally I don't think title should go in context
There was a problem hiding this comment.
does CarouselHeader make more sense than controls given the title is included in this component too? I think that is what making me noise
No description provided.