Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping new icon size to each header / display size #4433

Open
Tracked by #1107
origami-z opened this issue Nov 22, 2024 · 17 comments
Open
Tracked by #1107

Mapping new icon size to each header / display size #4433

origami-z opened this issue Nov 22, 2024 · 17 comments
Assignees

Comments

@origami-z
Copy link
Contributor

origami-z commented Nov 22, 2024

Figma proposal - https://www.figma.com/design/J7yk2qzpkrWd2S0tVFSINN/Icon-ramp-exploration?node-id=73-1823&t=2lpf1DkHe02UAhpn-1

@mark-tate
Copy link
Contributor

Mocca Goal: finalize proposal by EOS

@bhoppers2008
Copy link

Goal to get agreement on the icon mapping and have spec ready for dev or documenting.

@dplsek
Copy link

dplsek commented Dec 3, 2024

Reviewed proposal with @bhoppers2008 @pseys on 12.03.2024... overall direction seems supported by design but requires dev input. assuming it gains dev support, we would need to devise a rollout plan.

@origami-z
Copy link
Contributor Author

origami-z commented Dec 4, 2024

A lot of components will have visual regression around spacing and layout shift. This can't be rolled out easily. Will either need to wait until a breaking change, or manage it through other channels (e.g. styling options, entirely different theme, etc.).

Either way, this won't happen any time soon in the next month or two.

@mark-tate
Copy link
Contributor

red Eye: @Fercas123 refer to other ticket and baseline proposal ?
If not , we may need a tactical fix or live with a slight mis-alignment.

@dplsek
Copy link

dplsek commented Dec 16, 2024

New proposal here

Pending review with @pseys cc @navkaur76 @Fercas123 @bhoppers2008

@bhoppers2008
Copy link

Implementation needs to be discussed.
@Fercas123 to set up time with team + @joshwooding

@dplsek
Copy link

dplsek commented Jan 9, 2025

@dplsek to look at using line height for all text sizes and possibly replacing adornment, selectable, etc

@bhoppers2008
Copy link

Goal: Finalise strategy for aligning icons to headings/displays. @amritadesmet to suggest a place to document.

@mark-tate
Copy link
Contributor

tecno goal:
One more review of PR to enable title to flow multiline
Kris to review

@mark-tate mark-tate assigned navkaur76 and unassigned Fercas123 and dplsek Jan 21, 2025
@mark-tate
Copy link
Contributor

add Header block to new library, prioritized by EOW

@mark-tate
Copy link
Contributor

@navkaur76 can you post an update here

@mark-tate
Copy link
Contributor

review and qa meeting to be done today and merged by EOS

@mark-tate
Copy link
Contributor

Oregano Goal: update dialog with these changes by EOS

@navkaur76
Copy link
Contributor

Header block stickersheet in figma 90% complete. Pending a figma-only token which provides the needed spacing/padding to support alignment during multiline text display. Discussion started in header block teams chat.

@mark-tate
Copy link
Contributor

@navkaur76 can you post an update

@mark-tate
Copy link
Contributor

Figma tokens added by next standup
Merge header block by EOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

6 participants