-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping new icon size to each header / display size #4433
Comments
Mocca Goal: finalize proposal by EOS |
Goal to get agreement on the icon mapping and have spec ready for dev or documenting. |
Reviewed proposal with @bhoppers2008 @pseys on 12.03.2024... overall direction seems supported by design but requires dev input. assuming it gains dev support, we would need to devise a rollout plan. |
A lot of components will have visual regression around spacing and layout shift. This can't be rolled out easily. Will either need to wait until a breaking change, or manage it through other channels (e.g. styling options, entirely different theme, etc.). Either way, this won't happen any time soon in the next month or two. |
red Eye: @Fercas123 refer to other ticket and baseline proposal ? |
New proposal here Pending review with @pseys cc @navkaur76 @Fercas123 @bhoppers2008 |
Implementation needs to be discussed. |
@dplsek to look at using line height for all text sizes and possibly replacing adornment, selectable, etc |
Goal: Finalise strategy for aligning icons to headings/displays. @amritadesmet to suggest a place to document. |
tecno goal: |
add Header block to new library, prioritized by EOW |
@navkaur76 can you post an update here |
review and qa meeting to be done today and merged by EOS |
Oregano Goal: update dialog with these changes by EOS |
Header block stickersheet in figma 90% complete. Pending a figma-only token which provides the needed spacing/padding to support alignment during multiline text display. Discussion started in header block teams chat. |
@navkaur76 can you post an update |
Figma tokens added by next standup |
Figma proposal - https://www.figma.com/design/J7yk2qzpkrWd2S0tVFSINN/Icon-ramp-exploration?node-id=73-1823&t=2lpf1DkHe02UAhpn-1
The text was updated successfully, but these errors were encountered: