-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header Block component #3839
Comments
Need to think through how to play nicely with container's padding. e.g. Dialog has only top/bottom padding to make accent bar work. Drawer & Overlay have full paddings for the content (different spacing as well). |
Extend to 2 sprints, given multiple components, and user validation needed |
Figma spec complete. Ready for dev work to begin. |
Cortado Goal: |
@tomhazledine link to Figma spec |
Aug 12 - starting dev tomorrow (one minor design update remaining) |
Aug 13th - had header block dev kick-off with @tomhazledine @navkaur76 @pseys Open questions:
@bhoppers2008 @joshwooding would like to discuss more on these |
Meeting w/ @bhoppers2008 on Aug 14 Answers to Qs in Darrin's comment above:
Other:
|
Aug 16 - dev in-progress. Expect RC by end of Monday |
+1 sprint due to OOO and further design requirements |
Refactoring following dev feedback, expect PR ready for dev-review tomorrow (18th) |
Design review today, PR up for code review, examples may need updates ? |
design review complete for dialog and overlay, outstanding issue with scrolling |
Code changes following design review in-progress |
Galao Goal: dev complete by end of wk1 |
@tomhazledine do we have an update on this ? |
Latte: 1 week capacity |
No work to happen beyond pushing dialog and overlay header to labs in Latte. Updates to dialog/overlay core site examples and guidance and header block pattern page to be updated for core in Lungo sprint. |
Lungo Goal: no dev capacity this sprint |
Moved to Macchiato sprint. No capacity in Lungo. @navkaur76 can resume the work when she returns from holiday. @mark-tate |
Macc Goal: Design/Dev kickoff to re-align on sprint priorities and how we will deliver/QA related tickets and publish in Figma Plan in place for site updates |
Mocca Goal: MTK review from labs |
Need to make changes to the header block status to allow for multiline. Meeting tomorrow (Tuesday) with plan to merge in Figma. Nav to keep Fernanda up to date. |
Red Eye: BLOCKED - resolution for icon sizes to text sizes #4433 will unblock this story |
@Fercas123 baseline alignment - how easy would it be to use this to align text and icons ? |
Red Eye: Proposal to unblock by EOS |
|
Header Block merged to labs. @joshwooding New ticket to be created to move to core. |
This issue will standardize a Header Block which can be composed into container components (Dialog, Drawer, Overlay) and provide a Header Block component.
Requirements
The Header Block will include the following attributes:
-- Header Block won't be opinionated about which components can display its status states. Salt will provide relevant examples of use per component it is used in.
--spacing-300
.Component updates
The following components are updated to use the Header Block:
-- This will be the only example that shows status headers.
-- Padding-top/-bottom will be overwritten to
--spacing-200
to match the internal padding of Overlay.In all cases, if the container element needs to be closed via Close Button, the Header Block close button should be used.
Consideration: Should a Close Button component be created as it's own individual component?
Enhancement
An overflow drop-shadow will be added at a later point.
Closes #3532
Closes #2970
The text was updated successfully, but these errors were encountered: