Fix broken link to format specification on import page. #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that trying to click on the "format specification" link on the import page did not work, and this is my attempt to fix it. Note that I have nearly 0 experience with PHP and only slightly more with javascript, but I think this should work. (I also unfortunately did not know how to test this).
Looking at the generated HTML page, you can see the link appears to be pretty broken:
My fix is based on similar code in
html/settings.phpwhich does something similar and does seem to work. Namely I had to change most of the double quotes to single quotes and escape the double quotes used for arguments to window.open().I'm cautiously optimistic that this would fix the issue here.