Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improved Banner Thousands Separator Logic
Use `number_format` to generalize inserting the thousands separators. This fixes formatting for distances over 1 million. Tested numbers up to 1 billion. | Old format | New format | |--------------|----------------| | 1 | 1 | | 1,000 | 1,000 | | 1000,000 | 1,000,000 | | 1000000,000 | 1,000,000,000 | Fixes #153. Side notes: 1. We specify "," because the banner is in English. We could load the user's locale and use that but that would only make sense if we internationalized the whole banner. 2. The web UI doesn't have any thousands separator at all. Easy enough to add but ought to be done in a separate PR.
- Loading branch information