Fix local_art in Art tab and allow PNG downloads. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3808,7 +3808,11 @@ async function addTextbox(textboxType) { | |||
| } | |||
| //ART TAB | |||
| function uploadArt(imageSource, otherParams) { | |||
| art.src = imageSource; | |||
| if (!imageSource.includes('http')) { | |||
There was a problem hiding this comment.
The real fix for this is to actually update /creator/index.html line 303 to use onchange='imageURL(this.value, uploadArt, "autoFit");' instead of the uploadArt function.
| @@ -698,13 +698,13 @@ <h5 class='padding input-description'>Automatically update frame</h5> | |||
| <div class='readable-background padding'> | |||
| <h3 class='download padding' onclick='downloadCard();'>Download your card</h3> | |||
| <h5 onclick='downloadCard(false, true);' id='downloadJpg' href='' target='_blank' class='padding download input-description' style='text-align: left;'>Click here to download as JPEG</h5> | |||
| <h5 onclick='downloadCard(true);' id='downloadAlt' href='' target='_blank' class='padding download input-description' style='text-align: left;'>Click here for an alternative download</h5> | |||
| <h5 onclick='downloadCard(false, false);' id='downloadPng' href='' target='_blank' class='padding download input-description' style='text-align: left;'>Click here to download as PNG</h5> | |||
There was a problem hiding this comment.
This change makes it functionally the same as line 699 here.
Azerkatil
approved these changes
Dec 14, 2023
|
Is this still an issue? I think this was fixed elsewhere at some point. |
This is definitely still broken, I opened #52 to fix it based on this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friend asked me to look at the local_art not working in the art tab. Was a simple oversight and has been fixed.