Implement custom events #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hw-combobox:selection hw-combobox:valid hw-combobox:invalid
This makes the validity events redundant
josefarias
commented
Mar 7, 2024
| this.hiddenFieldTarget.value = null | ||
| this._setActiveDescendant("") | ||
|
|
||
| if (!option) this._dispatchSelectionEvent({ isNew: false }) |
There was a problem hiding this comment.
I find this placement a bit smelly. Good enough for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hw-combobox:selection custom event, the details of which describe the status of the combobox.
This also introduces a new feature where if the combobox value is unjustifiably blank (i.e. no blank option is selected but the value is empty), then we clear the query. In line with #70, and also aligns well with the ergonomics of being able to expect an hw-combobox:selection event every time the hidden field value changes.
Finally, this also fixes a bug in the memoization of canonical_id, adds the missing
.hw-combobox__input--invalidCSS class, and more completely adjusts validity in all comboboxes.