Allow pre-filling of free text inputs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows free text to be re-displayed just like an id-based value from the options will be re-displayed. This allows the form to be re-painted for search applications as well as re-displaying forms after validation errors that would create a new entry.
josefarias
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
@dringoen really appreciate you identifying the issue, coming up with a fix, and mentioning a use case in the description.
This is spectacular work. Thank you for your time on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows free text to be re-displayed just like an id-based value from the options will be re-displayed. This allows the form to be re-painted for search applications as well as re-displaying forms after validation errors that would create a new entry.
It covers the case where the free text is returned in the same field as selected-option values. I'm not sure I see anything in the design that allows pre-filling of fields named via name_when_new, which seems fine.
I have an application for this where a search result is based on either an option selection, or a full-text search based on a free text entry, and want to be able to re-draw the form with the same text displayed.
Thanks for an inspiring and useful gem!