Don't look inside functions #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update to checkout@v4
The assume macro has been present for a long time but has never been described in the documentation.
Authored-by: Stefan Monnier
Authored-by: Stefan Monnier
and correct comment `depth'. Authored-by: Stefan Monnier
Authored-by: Stefan Monnier
OClosures solves the problem in a much better way. Authored-by: Stefan Monnier
When `buttercup--wrap-expr' uses `buttercup-thunk' OClosures, it actually returns a form that has to be `eval'ed to get a `buttercup-thunk'. This is not an issue when `buttercup--wrap-expr' is used in the `expect' macro, because the expansion of `expect' will be read/eval:ed anyway. But in the tests the return will sometimes have to be explicitly evaled before it's processed by other functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @monnier in #241, use OClosures for the wrapped expressions.
Fixes #241.