-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2 ]#44636 add scroll-margin-top if sticky top is used #44679
base: 5.2-dev
Are you sure you want to change the base?
[5.2 ]#44636 add scroll-margin-top if sticky top is used #44679
Conversation
I have tested this item ✅ successfully on 18a850a Used 5.2.2 and Prebuilt Update_Package. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679. |
I have tested this item ✅ successfully on 18a850a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44679. |
Testet it on 5.2.3 still not working. need somebody to change the Css with next update of Joomla. |
@1405djarnis The Pull Request is not merged. |
|
Pull Request for Issue 44636 .
Summary of Changes
This PR has a css change. It will apply a scroll-margin-top when sticky header is used.
The value of
scroll-margin-top
is set by custom property--cassiopeia-scroll-margin-top
with a fallback to 10rem. Because custom property is used it can be set using javascript too. This might be useful when the height of the header is unknown. Out of scope for this PR.When header in your custom Cassiopea template is larger you can override
--cassiopeia-scroll-margin-top
to another value in user.css or use javascript to set it in the style element.Testing Instructions
#anchor
. Add it to Menu Blognpm ci
to compile new css. (or something similar... css needs to be recompiled)Actual result BEFORE applying this Pull Request
My set anchor position next to Your site is hidden behind the sticky header.
Expected result AFTER applying this Pull Request
My set anchor position next to Your site is visible below the sticky header.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed