Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: cleanup #3520

Merged
merged 1 commit into from
Sep 7, 2024
Merged

validation: cleanup #3520

merged 1 commit into from
Sep 7, 2024

Conversation

jknack
Copy link
Member

@jknack jknack commented Sep 7, 2024

  • make constrainctvalidation cast safe
  • use config api for properties
    @SentryMan can you look at locales?

Copy link
Contributor

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the validator should use the default system locale if none are provided

@jknack jknack force-pushed the validation branch 2 times, most recently from 7d2a821 to 4ae61a0 Compare September 7, 2024 17:19
- make constrainctvalidation cast safe
- use config api for properties
@jknack jknack merged commit ef8aa61 into 3.x Sep 7, 2024
5 checks passed
@kliushnichenko
Copy link
Contributor

@jknack Don't you want to add some .editorconfig to avoid manual code re-formatting? And maybe some contribution guide

@jknack
Copy link
Member Author

jknack commented Sep 7, 2024

we should add it yea. Today it uses spotless + git pre-commit hook that is installed on mvn clean package

@SentryMan
Copy link
Contributor

SentryMan commented Sep 7, 2024

I'm in the minority, but I use Eclipse, so .editorconfig doesn't do anything for me. Personally, I use the google java formatter to deal with formatting.

@jknack jknack deleted the validation branch September 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants