Bump hyper from 0.14.28 to 0.14.29 #139
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (5)
src/session.rs|749 col 70| warning: the borrowed expression implements the required traits
--> src/session.rs:749:70
|
749 | base64::engine::general_purpose::STANDARD.encode(&format!(
| _________________________________________________^
750 | | "{}:{}",
751 | | url.username(),
752 | | url.password().unwrap_or("")
753 | | ))
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: #[warn(clippy::needless_borrows_for_generic_args)]
on by default
help: change this to
|
749 ~ base64::engine::general_purpose::STANDARD.encode(format!(
750 + "{}:{}",
751 + url.username(),
752 + url.password().unwrap_or("")
753 ~ ))
|
src/session.rs|818 col 55| warning: deref which would be done by auto-deref
--> src/session.rs:818:55
|
818 | let body = match serde_json::from_str(&*body)? {
| ^^^^^^ help: try: &body
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: #[warn(clippy::explicit_auto_deref)]
on by default
src/session.rs|894 col 31| warning: match can be simplified with .unwrap_or_default()
--> src/session.rs:894:31
|
894 | let message = match body.remove("message") {
| _______________________________^
895 | | Some(Json::String(x)) => x,
896 | | _ => String::new(),
897 | | };
| |_________________^ help: replace it with: body.remove("message").unwrap_or_default()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
= note: #[warn(clippy::manual_unwrap_or_default)]
on by default
src/key.rs|212 col 9| warning: taken reference of right operand
--> src/key.rs:212:9
|
212 | String::new() + &self + rhs
| ^^^^^^^^^^^^^^^^-----
| |
| help: use the right value directly: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: #[warn(clippy::op_ref)]
on by default
src/key.rs|212 col 25| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/key.rs:212:25
|
212 | String::new() + &self + rhs
| ^^^^^ help: change this to: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)]
on by default