Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] maint: update versions.json sphinx link #991

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

asoplata
Copy link
Collaborator

@asoplata asoplata commented Feb 4, 2025

Now that #971 is merged, we need to make a very small follow-up change to fix a circular dependency, which is in this PR. Merging #971 has created a new file available at https://jonescompneurolab.github.io/hnn-core/dev/_static/versions.json . This file, which is now publicly accessible, can be used as the proper versions.json for all documentation site builds going forward. This updates the dev build of the documentation so that it uses this new file (which is ALSO updated itself through the dev doc build).

After this, anytime we want to rename or add an additional version (like when we make a release), we only need to edit the file referenced in config line in this PR.

Copy link
Collaborator

@dylansdaniels dylansdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@ntolley ntolley merged commit 97a9738 into jonescompneurolab:master Feb 5, 2025
12 checks passed
@ntolley
Copy link
Contributor

ntolley commented Feb 5, 2025

Definitely appreciate having a more concise system for updating this, great work @asoplata !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants