Update hs-notice.php to fix 2 annoying notices under WP 4.2.x and later #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a notice that appears under WordPress 4.2.x and later. In the version of hs-notice that also has this line:
if ( $_GET['page'] != 'hubspot_activate')
change it to:
if (!empty($_GET['page']) && $_GET['page'] != 'hubspot_activate')
Cheers!
-Lorin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these two notices that appear under WordPress 4.2.x and later:
Notice: Undefined index: page in /Users/???/Sites/???/wp-content/plugins/hubspot/inc/hs-notice.php on line 20
Strict Standards: Non-static method WPHubspot::hs_is_customer() should not be called statically, assuming $this from incompatible context in /Users/???/Sites/???/wp-content/plugins/hubspot/inc/hs-notice.php on line 23
In the version of hs-notice that also has this line:
change it to:
Cheers!
-Lorin