A few minor clippy suggestions #669
Closed
+181
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 65.02% 65.10% +0.08%
==========================================
Files 36 36
Lines 2187 2181 -6
==========================================
- Hits 1422 1420 -2
+ Misses 765 761 -4 ☔ View full report in Codecov by Sentry. |
* Added cargo.toml lints section (will be ignored by older cargo) * fixed a number of suggestions, and added exceptions to the other ones * Added `From<i64> for Sign`, and a few more minor improvements
jonasbb
added a commit
that referenced
this pull request
Jan 2, 2024
Co-Authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
|
Thank you for the PR. I do like some of the changes you made. Enabling all of clippys pedantic warnings is too much. I pulled some changes into #674. I took your spelling fixes and match refactorings. I credited you for the commits and PR |
jonasbb
added a commit
that referenced
this pull request
Jan 2, 2024
Co-Authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From<i64> for Sign, and a few more minor improvements