Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit Gallery RSS #10

Closed

Conversation

JosephDeFazio
Copy link

This closes #6. Previously, imgur galleries were supported, but native Reddit galleries were not.

I've left plenty of comments to show why decisions were made. I also built a Docker image locally to test this with Miniflux and it looks good to me.

image

@johnwarne
Copy link
Owner

@JosephDeFazio Thanks so much! Apologies, I've been MIA on this project due to life stuff.

Today I finally got fed up with Reddit galleries not appearing in my feeds, so I decided to rectify that. I did a lot of exploration and then made a branch for this functionality. I was just about to push when I went into the repo and saw your PR 🤦‍♂️. Fantastic work… I'm just wishing I would have seen it sooner.

Going over your code and your super helpful comments, I noticed some similarities and some discrepancies between my branch feature/redditGalleries and yours:

  • We both settled on ["media_metadata"]["p"]["3"]["u"] for similar reasons, and we're linking to those images in the $itemDescription.
  • I did notice that galleries don't appear in the JSON for items that have been crossposted. To get around this, I did another JSON loop/cache cycle within the switch case to get the JSON for the item's original post so that I could grab the ["media_metadata"] from there and parse it out.
  • Another difference is that I'm linking to the full-size image but only embedding the smaller ["p"]["3"]["u"] option to make it easier on bandwidth until a user chooses to open the full-size image.

Would you mind taking a look at my branch and letting me know your thoughts? Thanks!

johnwarne added a commit that referenced this pull request Oct 28, 2021
@johnwarne johnwarne closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reddit gallery images are not displayed
2 participants