Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards-compatibility for jQuery versions before 1.6 #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akalata
Copy link
Contributor

@akalata akalata commented Oct 26, 2017

No description provided.

@nebrot
Copy link

nebrot commented Oct 27, 2017

jQuery 1.5 is nearly seven years old, this is a huge period in world wide web.
Upgrade to at least jQuery 1.7 for current 1.0.3, see https://github.com/johnpolacek/stacktable.js/blob/master/stacktable.js#L11

@akalata
Copy link
Contributor Author

akalata commented Oct 27, 2017

I would love to! Will you be paying my rate to test all of the other javascript that exists on my client's website to ensure that it all works correctly?

Snark aside, I get it. But not everybody has the ability to go changing the jQuery version of their projects or dealing with noConflict. It was an simple enough change, and if the maintainer doesn't want to use it, that's fine too. Maybe it will help somebody else stuck supporting a technically-supported-but-10-years-out-of-date CMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants