Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub scraping example in GUIDE.md #1424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JosXa
Copy link
Contributor

@JosXa JosXa commented Jan 11, 2024

Was trying out the example, seems the span is required to get to the anchor now.

Without:

[2024-01-11 22:32:22.571] [info]  []

With:

[2024-01-11 22:33:35.211] [info]  [{"link":"https://github.com/johnlindquist/kit","title":"kit"},{"link":"https://github.com/johnlindquist/angularjs-plugin","title":"angularjs-plugin"},{"link":"https://github.com/johnlindquist/react-streams","title":"react-streams"},{"link":"https://github.com/johnlindquist/angular-resolve","title":"angular-resolve"},{"link":"https://github.com/johnlindquist/rx-handler","title":"rx-handler"},{"link":"https://github.com/johnlindquist/intro-to-angular2","title":"intro-to-angular2"}]

@JosXa
Copy link
Contributor Author

JosXa commented Jun 20, 2024

It's approved. Merge too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants