-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed handling for when a person has multiple positions under a company #151
base: master
Are you sure you want to change the base?
Conversation
Hi, can you please resolve the merge conficts, then I'll merge this in? Thanks |
Please merge this asap, I'm getting the same issue. |
Yep, conflicts resolved. |
this pr doesn't work anymore
|
if position_summary_text and len( | ||
position_summary_text.find_element_by_class_name("pvs-list").find_element_by_class_name("pvs-list").find_elements_by_xpath("li")) > 1: | ||
descriptions = position_summary_text.find_element_by_class_name("pvs-list").find_element_by_class_name("pvs-list").find_elements_by_xpath("li") | ||
if position_summary_text and len(position_summary_text.find_element(By.CLASS_NAME,"pvs-list").find_element(By.CLASS_NAME,"pvs-list").find_elements(By.XPATH,"li")) > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This element is missing in some profiles i check
@shanedoolane if you fork this, fix it, and submit a PR, I'll merge it in and deploy |
I was getting an error that the work_time variable wasn't set when trying to scrape my own experiences: https://www.linkedin.com/in/myrongt/details/experience/
This was because I have had multiple positions with the same company.
This change fixes that issue.