Editorial: Allocate-and-use in MakeMatchIndicesIndexPairArray for ref…

…inement (tc39#3495)
jmdyck · Jan 16, 2025 · 1f6ac07 · 1f6ac07
1 parent e645d2c
commit 1f6ac07
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/esmeta-ignore.json b/esmeta-ignore.json
@@ -7,7 +7,6 @@
   "FunctionBody[0,0].EvaluateFunctionBody",
   "GetViewByteLength",
   "INTRINSICS.Atomics.notify",
-  "MakeMatchIndicesIndexPairArray",
   "Record[SourceTextModuleRecord].ExecuteModule",
   "TypedArrayGetElement",
   "TypedArrayLength",

diff --git a/spec.html b/spec.html
@@ -38812,11 +38812,12 @@ <h1>
             1. Else,
               1. Let _matchIndexPair_ be *undefined*.
             1. Perform ! CreateDataPropertyOrThrow(_A_, ! ToString(𝔽(_i_)), _matchIndexPair_).
-            1. If _i_ > 0 and _groupNames_[_i_ - 1] is not *undefined*, then
-              1. Assert: _groups_ is not *undefined*.
+            1. If _i_ > 0, then
               1. Let _s_ be _groupNames_[_i_ - 1].
-              1. NOTE: If there are multiple groups named _s_, _groups_ may already have an _s_ property at this point. However, because _groups_ is an ordinary object whose properties are all writable data properties, the call to CreateDataPropertyOrThrow is nevertheless guaranteed to succeed.
-              1. Perform ! CreateDataPropertyOrThrow(_groups_, _s_, _matchIndexPair_).
+              1. If _s_ is not *undefined*, then
+                1. Assert: _groups_ is not *undefined*.
+                1. NOTE: If there are multiple groups named _s_, _groups_ may already have an _s_ property at this point. However, because _groups_ is an ordinary object whose properties are all writable data properties, the call to CreateDataPropertyOrThrow is nevertheless guaranteed to succeed.
+                1. Perform ! CreateDataPropertyOrThrow(_groups_, _s_, _matchIndexPair_).
           1. Return _A_.
         </emu-alg>
       </emu-clause>