fix!: detach format lifetime from worksheet #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the lifetime of `Format` inside `IntoExcelData::write_to_format` is bound to the lifetime of the worksheet. However, this is not actually required anywhere in the code, and with this constraint it is not possible to create abstractions with an internal formatter because, once the ownership of the data is taken by `write_with_format`, the stored format cannot outlive the call. This breaking change should simplify the management of formatters.
|
Ignore the clippy fail. It is due to a newer version of clippy with updated rules. I'll fix that. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #85
At the moment the lifetime of
FormatinsideIntoExcelData::write_to_formatis bound to the lifetime of the worksheet. However, this is not actually required anywhere in the code, and with this constraint it is not possible to create abstractions with an internal formatter because, once the ownership of the data is taken bywrite_with_format, the stored format cannot outlive the call.This breaking change should simplify the management of formatters.