-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] TalkRoom 좋아요, 검색 쿼리 기능 구현 #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 필드가 하나 누락 된 것 같아 리뷰 남겼습니다. 확인 부탁드립니다!
public TalkRoomSearchServiceRequest toService() { | ||
return TalkRoomSearchServiceRequest.builder() | ||
.page(page) | ||
.size(size) | ||
.order(order) | ||
.orderType(OrderType.conversionOrderType(order)) | ||
.build(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search
를 넘기시는 것을 깜빡 하신 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇! 그러네요! 바로 수정해서 올리도록 하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 확인했습니다.
고생하셨습니다 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
내용 확인했습니다 ~ 😊
의견에 답변 남겨주세요 !
public static OrderType conversionOrderType(String order) { | ||
return switch (order) { | ||
case "recent" -> RECENT; | ||
case "recommend" -> RECOMMEND; | ||
default -> RECENT; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변환 메서드명 convertToOrderType
은 어떠신가요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 수정 후 다시 올리겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다. 👍
💡 연관된 이슈
close #40
📝 작업 내용
💬 리뷰 요구 사항
최신순, 좋아요 정렬 기능 추가 및 where절 검색 조건 기능 구현 했습니다.
그리고 RepositoryImpl에 각 메서드 기능별 설명 주석으로 달아놨습니다!