[Feature] TalkRoom Comment 등록 API 구현 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pdohyung
approved these changes
Mar 24, 2024
Comment on lines
+20
to
+51
| @SpringBootTest | ||
| @AutoConfigureMockMvc | ||
| class CommentControllerTest { | ||
|
|
||
| @MockBean | ||
| CommentService commentService; | ||
|
|
||
| @Autowired | ||
| MockMvc mockMvc; | ||
|
|
||
| @Autowired | ||
| ObjectMapper objectMapper; | ||
|
|
||
| @Test | ||
| @DisplayName("유저가 토크방에 자신의 의견을 작성한다.") | ||
| void writeComment() throws Exception { | ||
| // given | ||
| CommentCreateRequest request = CommentCreateRequest.builder() | ||
| .content("의견을 작성하다") | ||
| .build(); | ||
|
|
||
| // when // then | ||
| mockMvc.perform(post("/v1/talk-rooms/1/comments") | ||
| .content(objectMapper.writeValueAsString(request)) | ||
| .contentType(APPLICATION_JSON) | ||
| ) | ||
| .andDo(print()) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.code").value("200")) | ||
| .andExpect(jsonPath("$.status").value("OK")) | ||
| .andExpect(jsonPath("$.message").value("OK")); | ||
| } |
There was a problem hiding this comment.
@Auth에 담겨있는 userId를 넘겨주는 부분을 테스트에서 잘 처리하셨네요.
@MockBean 덕분에 controller -> service의 구간을 쉽게 통과할 수 있나요 ?
There was a problem hiding this comment.
네네!
@MockBean을 사용하면 테스트 시에는 commentService가 직접 실행되는 것이 아니라 MockBean이 대신 실행되어, 해당 동작이 정상적으로 이루어졌다고 가정하고 테스트를 진행합니다!
jwooo
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #24
📝 작업 내용
💬 리뷰 요구 사항
이번 코드는 간단하게 등록 API만 작성한거라 리뷰 요구 사항은 없습니다!