Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/X][Pipeline] Add basic deployment generation in python #45

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jiaodong
Copy link
Owner

@jiaodong jiaodong commented Feb 23, 2022

This PR is not fully ready with all tests added and passed yet, but putting it up for initial review to speed up landing process.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jiaodong
Copy link
Owner Author

jiaodong commented Feb 23, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jiaodong jiaodong force-pushed the dag_generation_python branch from dc4f2b0 to 9a9b5c7 Compare February 23, 2022 05:20
@jiaodong jiaodong mentioned this pull request Feb 23, 2022
6 tasks
@jiaodong jiaodong force-pushed the dag_generation_python branch from 9a9b5c7 to ab5e819 Compare February 23, 2022 05:32
@jiaodong jiaodong requested a review from edoakes February 24, 2022 06:48
@jiaodong jiaodong changed the title wip [2/X][Pipeline] Add basic deployment generation in python Feb 24, 2022
@jiaodong jiaodong marked this pull request as ready for review February 24, 2022 06:49
@jiaodong jiaodong removed the request for review from edoakes February 24, 2022 06:58
@jiaodong jiaodong changed the base branch from deployment_node to master February 24, 2022 07:10
@jiaodong jiaodong force-pushed the dag_generation_python branch from 9d4c936 to abff066 Compare February 24, 2022 07:10
@edoakes
Copy link
Collaborator

edoakes commented Feb 24, 2022

opened this on the wrong repo my dude

@edoakes edoakes closed this Feb 24, 2022
@jiaodong
Copy link
Owner Author

yeah ... I might did something weird dabbling graphite again and gt stack submit produces to my origin =.= but the one you just reviewed is created from this via a few more UI clicks.

@jiaodong jiaodong reopened this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants