Handle integers bigger than 64bit #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capacity of handling arbitrary size integers is quite important to be able to replace the stdlib library. Unfortunately RapidJSON isn't very flexible here. For generating JSON it's quite easy to fallback to `Integer#to_s`. However for parsing, the only escape hatch is to parse all integers ourselves, which significantly impact performance. It could be a bit better by parsing in place, but all Ruby functions expect null terminated C-strings, so it wouldn't work well. Ruby number parsing is also not as fast at RapidJSON's. So for this to be performant, RapidJSON would need a flag that allows to only parse over-sized integers ourself, and not all numbers. But that would require a new feature upstream.
casperisfine
force-pushed
the
handle-bignum
branch
from
34990ab to
e8dfd22
Compare
|
So Tencent/rapidjson#2155 would allow to really keep the overhead down in the vast majority of cases where the number fits No idea if it has any chance to be accepted upstream though. |
casperisfine
pushed a commit
to casperisfine/rapidjson-ruby
that referenced
this pull request
May 17, 2023
BigNum are expected to be rare, so calling `Integer#to_s` while not super fast is fast enough and simpler than checking bounds. Ref: jhawthorn#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capacity of handling arbitrary size integers is quite important to be able to replace the stdlib library.
Unfortunately RapidJSON isn't very flexible here.
For generating JSON it's quite easy to fallback to
Integer#to_s.However for parsing, the only escape hatch is to parse all integers ourselves, which significantly impact performance.
It could be a bit better by parsing in place, but all Ruby functions expect null terminated C-strings, so it wouldn't work well.
Ruby number parsing is also not as fast at RapidJSON's.
So for this to be performant, RapidJSON would need a flag that allows to only parse over-sized integers ourself, and not all numbers.
But that would require a new feature upstream.
(opening as a draft for comments, but I don't think it's mergeable in this state)